[Backport 3.3] Disable query rewriter as a default behaviour#19593
Merged
rishabhmaurya merged 1 commit intoopensearch-project:3.3from Oct 10, 2025
Merged
Conversation
3377a10 to
1a35fdc
Compare
andrross
approved these changes
Oct 10, 2025
jainankitk
approved these changes
Oct 10, 2025
| - Bump opensearch-protobufs dependency to 0.18.0 and update transport-grpc module compatibility ([#19447](https://github.com/opensearch-project/OpenSearch/issues/19447)) | ||
| - Bump opensearch-protobufs dependency to 0.19.0 ([#19453](https://github.com/opensearch-project/OpenSearch/issues/19453)) | ||
| - Add a function to SearchPipelineService to check if system generated factory enabled or not ([#19545](https://github.com/opensearch-project/OpenSearch/pull/19545)) | ||
| - Disable query rewriting framework as a default behaviour ([#19592](https://github.com/opensearch-project/OpenSearch/pull/19592)) |
Contributor
There was a problem hiding this comment.
Can you add this to 3.3 release notes as well?
Contributor
There was a problem hiding this comment.
Ideally, we need the entry in CHANGELOG.md as well. Can be done as separate PR or here if the gradle check fails
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 8506d93) Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
1a35fdc to
90afe39
Compare
66 tasks
Contributor
|
❕ Gradle check result for 90afe39: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #19593 +/- ##
============================================
+ Coverage 72.99% 73.04% +0.05%
- Complexity 70482 70522 +40
============================================
Files 5717 5717
Lines 323055 323056 +1
Branches 46794 46794
============================================
+ Hits 235798 235990 +192
+ Misses 68237 68066 -171
+ Partials 19020 19000 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 8506d93)
Description
Disable query rewriter as a default behaviour. There have been several issues reported so far. Listing them here soon
main PR #19592
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#19266
#19566
opensearch-project/dashboards-observability#2497 (no details on the issue yet, but information was shared offline that showed the test failure goes away if this setting is disabled)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.