Wipe request cache on mapper updates that can change query results#19346
Closed
peteralfonsi wants to merge 8 commits intoopensearch-project:mainfrom
Closed
Wipe request cache on mapper updates that can change query results#19346peteralfonsi wants to merge 8 commits intoopensearch-project:mainfrom
peteralfonsi wants to merge 8 commits intoopensearch-project:mainfrom
Conversation
added 6 commits
September 16, 2025 14:41
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
…ueries Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Contributor
|
❌ Gradle check result for e1fc27d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Sep 20, 2025
Contributor
|
❌ Gradle check result for d689fbd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
1 task
This was referenced Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wipes the request cache for an index when mapper updates that can change query results for that index happen. This is done by comparing mapping before and after in IndicesClusterStateService. It was done this way because there wasn't a good way of having the Mapper objects themselves communicate the results of their merge back out - see this comment for more.
Any other ParametrizedFieldMapper inheritors which want to register parameters that can affect query results, and therefore should cause cache clear, can override their TypeParser with one that provides those parameters in its
getParametersAffectingQueryResults()method. See how it's done in the KeywordFieldMapper for an example. This should work for non-core mappers too.Related Issues
Resolves #19279
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.