Conversation
|
❌ Gradle check result for 5180b1a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
It make sense to me. But it seems not delegate all methods, such as |
|
In #17575, it doesn't actually need You're absolutely right about I'll add a unit test that uses reflection to enforce overrides of all methods to catch mistakes if anyone adds more methods to |
server/src/main/java/org/opensearch/index/mapper/FilterFieldType.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17627 +/- ##
============================================
- Coverage 72.41% 72.36% -0.05%
+ Complexity 65880 65868 -12
============================================
Files 5326 5327 +1
Lines 305548 305601 +53
Branches 44322 44322
============================================
- Hits 221258 221155 -103
- Misses 66101 66359 +258
+ Partials 18189 18087 -102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❕ Gradle check result for 6a83731: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
This class allows developers (in core or plugins) to wrap an existing field type, delegating all behavior by default, overriding specific methods as needed. Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: Michael Froh <froh@amazon.com>
After thinking about it some more, the type parameter doesn't really give us anything. Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: Michael Froh <froh@amazon.com>
6a83731 to
36ee328
Compare
|
❌ Gradle check result for 36ee328: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Michael Froh <froh@amazon.com>
|
❌ Gradle check result for 3759210: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Michael Froh <froh@amazon.com>
Signed-off-by: Michael Froh <froh@amazon.com>
|
❕ Gradle check result for 2b86bd7: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
This class allows developers (in core or plugins) to wrap an existing field type, delegating all behavior by default, overriding specific methods as needed.
See linked issue for more details.
Related Issues
Resolves #17624
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.