fail fast LeaderCheck on CoordinationStateRejectedException#17400
fail fast LeaderCheck on CoordinationStateRejectedException#17400anuragrai16 wants to merge 10 commits intoopensearch-project:mainfrom
Conversation
cb70223 to
c60fc77
Compare
|
❌ Gradle check result for c60fc77: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
72452c7 to
9292aa3
Compare
|
❌ Gradle check result for 9292aa3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/cluster/coordination/LeaderChecker.java
Outdated
Show resolved
Hide resolved
|
This PR is stalled because it has been open for 30 days with no activity. |
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
67e8bef to
a385bf3
Compare
|
❌ Gradle check result for a385bf3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
yupeng9
left a comment
There was a problem hiding this comment.
overall looks good. can you add a changelog for this?
Signed-off-by: Anurag Rai <91844619+anuragrai16@users.noreply.github.com>
|
❌ Gradle check result for c5b0861: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
|
❌ Gradle check result for b9571f6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
|
❌ Gradle check result for beec41a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Flaky tests, org.opensearch.upgrades.FullClusterRestartIT.testRecovery org.opensearch.remotestore.RestoreShallowSnapshotV2IT.testHashedPrefixTranslogMetadataCombination {p0={"opensearch.experimental.feature.writable_warm_index.enabled":"true"}} org.opensearch.remotestore.RestoreShallowSnapshotV2IT.testContinuousIndexing {p0={"opensearch.experimental.feature.writable_warm_index.enabled":"true"}} |
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
|
❕ Gradle check result for a26e390: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17400 +/- ##
============================================
- Coverage 72.86% 72.76% -0.10%
+ Complexity 68571 68459 -112
============================================
Files 5566 5566
Lines 314513 314678 +165
Branches 45636 45653 +17
============================================
- Hits 229167 228984 -183
- Misses 66789 67079 +290
- Partials 18557 18615 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Bukhtawar thoughts on this change behind the flag? |
Description
This PR adds a provision to fail-fast the leaderCheck quickly if a
CoordinationStateRejectedExceptionexception is received. Please see the related issue for more details. This puts the fail-fast behind a dynamic setting "cluster.fault_detection.leader_check.fail_fast_on_state_rejection" that isfalseby default.Related Issues
Resolves #17155
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.