[Pull-based Ingestion] use ConfigurationUtil for KafkaSourceConfig#17223
Merged
msfroh merged 3 commits intoopensearch-project:mainfrom Feb 5, 2025
Merged
[Pull-based Ingestion] use ConfigurationUtil for KafkaSourceConfig#17223msfroh merged 3 commits intoopensearch-project:mainfrom
msfroh merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17223 +/- ##
============================================
+ Coverage 72.24% 72.33% +0.09%
- Complexity 65704 65756 +52
============================================
Files 5318 5319 +1
Lines 305674 305735 +61
Branches 44349 44360 +11
============================================
+ Hits 220834 221163 +329
+ Misses 66769 66460 -309
- Partials 18071 18112 +41 ☔ View full report in Codecov by Sentry. |
Contributor
|
❌ Gradle check result for 9751caf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Bukhtawar
reviewed
Feb 2, 2025
libs/core/src/main/java/org/opensearch/core/util/ConfigurationUtils.java
Outdated
Show resolved
Hide resolved
Contributor
msfroh
approved these changes
Feb 5, 2025
This was referenced Jan 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by the ConfigurationUtil in the ingest package, introduce a ConfigurationUtil to the common util (and later can consolidate with the one in ingest package).
used this configurationUtil for configuration parsing in KafkaSourceConfig
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.