[Backport 2.x] Experimental gRPC transport plugin#16954
[Backport 2.x] Experimental gRPC transport plugin#16954andrross merged 1 commit intoopensearch-project:2.xfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16954 +/- ##
============================================
- Coverage 71.89% 71.86% -0.04%
+ Complexity 65511 65502 -9
============================================
Files 5314 5316 +2
Lines 305467 305588 +121
Branches 44509 44516 +7
============================================
- Hits 219615 219596 -19
- Misses 67545 67688 +143
+ Partials 18307 18304 -3 ☔ View full report in Codecov by Sentry. |
Looks like the 19 commits from the original PR were brought in, as opposed to cherry picking the merged commit. Probably doesn't matter in practice but I'd prefer to cherry pick the actual merged commit and resolve conflicts.
c5add5f to
0a7bade
Compare
|
❌ Gradle check result for 0a7bade: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Introduce auxiliary transport to NetworkPlugin and add gRPC plugin. Auxiliary transports are optional lifecycle components provided by network plugins which run in parallel to the http server/native transport. They are distinct from the existing NetworkPlugin interfaces of 'getTransports' and 'getHttpTransports' as auxiliary transports are optional. Each AuxTransport implements it's own 'aux.transport.type' and 'aux.transport.<type>.ports' setting. Since Security.java initializes previous to Node.java during bootstrap socket binding permissions are granted based on 'aux.transport.<type>.ports' for each enabled 'aux.transport.type', falling back to a default if no ports are specified. Signed-off-by: Finn Carroll <carrofin@amazon.com> (cherry picked from commit 7a0e8fb)
0a7bade to
7bbe9bd
Compare
|
❌ Gradle check result for 7bbe9bd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Backport 7a0e8fb from #16534.