[Backport 2.x] Fix unclosed store references with SearchOnlyReplicaIT#16435
Merged
[Backport 2.x] Fix unclosed store references with SearchOnlyReplicaIT#16435
Conversation
… is unknown. (#16106) This PR fixes a bug with node-node pull based replication where if the replica does not know the DiscoveryNode of its primary we would fail after constructing a SegmentReplicationTarget that holds a store reference. Only after replication is started would a failure occur because the source node is null, and the target would not get cleaned up. Push based replication already handled this case by catching any error and closing the target. This update ensures the validation is done before constructing our PrimaryShardReplicationSource, before any target object is created in both cases push and pull. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit 267c68e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jainankitk
approved these changes
Oct 22, 2024
dbwiddis
approved these changes
Oct 22, 2024
Contributor
|
❌ Gradle check result for 2eb3e49: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16435 +/- ##
============================================
+ Coverage 71.75% 71.81% +0.05%
- Complexity 65231 65344 +113
============================================
Files 5312 5312
Lines 304646 304913 +267
Branches 44324 44423 +99
============================================
+ Hits 218604 218969 +365
+ Misses 67796 67708 -88
+ Partials 18246 18236 -10 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 267c68e from #16106.