Skip to content

Consider primary term while deleting generations#15981

Closed
sachinpkale wants to merge 5 commits intoopensearch-project:mainfrom
sachinpkale:gc-optimizations-gen-primary-term
Closed

Consider primary term while deleting generations#15981
sachinpkale wants to merge 5 commits intoopensearch-project:mainfrom
sachinpkale:gc-optimizations-gen-primary-term

Conversation

@sachinpkale
Copy link
Copy Markdown
Member

Description

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for 18e7975: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 64.89362% with 66 lines in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (3937ccb) to head (70b4817).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...index/translog/RemoteFsTimestampAwareTranslog.java 69.23% 27 Missing and 5 partials ⚠️
...remotestore/RemoteStorePinnedTimestampService.java 56.66% 10 Missing and 3 partials ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 20.00% 8 Missing ⚠️
...dex/translog/transfer/TranslogTransferManager.java 73.91% 6 Missing ⚠️
...ex/translog/transfer/TranslogTransferMetadata.java 50.00% 3 Missing ⚠️
...earch/index/store/RemoteSegmentStoreDirectory.java 77.77% 1 Missing and 1 partial ⚠️
...ava/org/opensearch/snapshots/SnapshotsService.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15981      +/-   ##
============================================
+ Coverage     71.90%   72.01%   +0.11%     
- Complexity    64392    64430      +38     
============================================
  Files          5278     5278              
  Lines        300877   300983     +106     
  Branches      43478    43498      +20     
============================================
+ Hits         216351   216764     +413     
+ Misses        66747    66413     -334     
- Partials      17779    17806      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2f8e2af: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale force-pushed the gc-optimizations-gen-primary-term branch from 2f8e2af to 70b4817 Compare September 19, 2024 01:33
@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for 70b4817: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@sachinpkale sachinpkale force-pushed the gc-optimizations-gen-primary-term branch from fffdd66 to 2b0723f Compare September 19, 2024 10:01
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for fffdd66: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for 2b0723f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Oct 19, 2024
@kotwanikunal
Copy link
Copy Markdown
Member

Stalled draft PR. Please reopen if you are still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog stalled Issues that have stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants