Skip to content

[Backport 2.17] Restore snapshot changes for shallow snapshot V2 (#15462)#15738

Merged
sachinpkale merged 1 commit intoopensearch-project:2.17from
sachinpkale:backport-15462-to-2.17
Sep 5, 2024
Merged

[Backport 2.17] Restore snapshot changes for shallow snapshot V2 (#15462)#15738
sachinpkale merged 1 commit intoopensearch-project:2.17from
sachinpkale:backport-15462-to-2.17

Conversation

@sachinpkale
Copy link
Copy Markdown
Member

@sachinpkale sachinpkale commented Sep 5, 2024

Backport 7a9cb35 from #15462

Conflicts in: IndexShard and StoreRecovery classes.

Version is changed in RecoverySource and RestoreSnapshotRequest from CURRENT to 2.17.0

@sachinpkale sachinpkale force-pushed the backport-15462-to-2.17 branch from 56a5dbe to befd1fa Compare September 5, 2024 08:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 56a5dbe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for befd1fa: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 31.14754% with 126 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (75fb5bc) to head (68f2190).
Report is 7 commits behind head on 2.17.

Files with missing lines Patch % Lines
...java/org/opensearch/index/shard/StoreRecovery.java 0.00% 61 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 26.47% 20 Missing and 5 partials ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 22.22% 11 Missing and 3 partials ⚠️
...org/opensearch/cluster/routing/RecoverySource.java 52.38% 6 Missing and 4 partials ⚠️
...ster/snapshots/restore/RestoreSnapshotRequest.java 33.33% 3 Missing and 5 partials ⚠️
...rg/opensearch/index/translog/RemoteFsTranslog.java 25.00% 1 Missing and 2 partials ⚠️
.../org/opensearch/index/translog/TranslogConfig.java 50.00% 2 Missing ⚠️
...search/snapshots/InternalSnapshotsInfoService.java 84.61% 1 Missing and 1 partial ⚠️
...n/java/org/opensearch/repositories/Repository.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.17   #15738      +/-   ##
============================================
+ Coverage     71.66%   71.71%   +0.04%     
- Complexity    64317    64420     +103     
============================================
  Files          5262     5263       +1     
  Lines        301148   301332     +184     
  Branches      43841    43877      +36     
============================================
+ Hits         215829   216105     +276     
+ Misses        67259    67143     -116     
- Partials      18060    18084      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale @gbbafna
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
68f2190 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
@sachinpkale sachinpkale force-pushed the backport-15462-to-2.17 branch from befd1fa to 68f2190 Compare September 5, 2024 15:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 68f2190: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 68f2190: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 5, 2024
Closed
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 68f2190: SUCCESS

@sachinpkale sachinpkale merged commit 97c4f82 into opensearch-project:2.17 Sep 5, 2024
This was referenced Sep 6, 2024
Open
Closed
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sachinpkale @Bukhtawar @gbbafna