Skip to content

[Backport 2.17] [Backport 2.x] [Star Tree] Scaled Float Support#15689

Closed
opensearch-trigger-bot[bot] wants to merge 1 commit into2.17from
backport/backport-15660-to-2.17
Closed

[Backport 2.17] [Backport 2.x] [Star Tree] Scaled Float Support#15689
opensearch-trigger-bot[bot] wants to merge 1 commit into2.17from
backport/backport-15660-to-2.17

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot Bot commented Sep 4, 2024

Backport c801270 from #15660.

@github-actions
[Star Tree] Scaled Float Support (#15442) (#15660)
da9985c 
---------

(cherry picked from commit 23f5c2f)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c801270)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2024

❌ Gradle check result for da9985c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2024

❌ Gradle check result for da9985c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2024

❌ Gradle check result for da9985c: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2024

❌ Gradle check result for da9985c:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 5, 2024

✅ Gradle check result for da9985c: SUCCESS

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.77778% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.67%. Comparing base (ccae165) to head (da9985c).
⚠️ Report is 47 commits behind head on 2.17.

Files with missing lines Patch % Lines
...startree/builder/AbstractDocumentsFileManager.java 79.16% 2 Missing and 3 partials ⚠️
...datacube/startree/builder/BaseStarTreeBuilder.java 50.00% 1 Missing and 4 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 20.00% 0 Missing and 4 partials ⚠️
...pensearch/index/mapper/ScaledFloatFieldMapper.java 60.00% 2 Missing ⚠️
...org/opensearch/index/mapper/NumberFieldMapper.java 87.50% 1 Missing and 1 partial ⚠️
...ube/startree/aggregators/MetricAggregatorInfo.java 75.00% 1 Missing ⚠️
...g/opensearch/index/mapper/DocCountFieldMapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.17   #15689      +/-   ##
============================================
- Coverage     71.73%   71.67%   -0.07%     
+ Complexity    64250    64228      -22     
============================================
  Files          5251     5251              
  Lines        300362   300439      +77     
  Branches      43704    43726      +22     
============================================
- Hits         215471   215344     -127     
- Misses        66908    67136     +228     
+ Partials      17983    17959      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Sep 6, 2024
Open
Open
Open
@reta reta added the v2.17.1 Issues and PRs related to version 2.17.1 label Sep 16, 2024
@reta
Copy link
Copy Markdown
Contributor

reta commented Sep 16, 2024

The 2.17.0 release has sailed away, this change was not included, @sachinpkale please target 2.17.1 if it is still planned for a possible patch release

@sarthakaggarwal97
Copy link
Copy Markdown
Contributor

sarthakaggarwal97 commented Sep 16, 2024

@reta got this merged as a part of this: #15716
Will close this PR. It's outdated! thanks for bringing this up

@andrross andrross deleted the backport/backport-15660-to-2.17 branch October 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

No one assigned

Labels

skip-changelog v2.17.1 Issues and PRs related to version 2.17.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reta @sarthakaggarwal97