Compare numbers with equals() instead of ==#15355
Draft
dk2k wants to merge 1 commit intoopensearch-project:mainfrom
Draft
Compare numbers with equals() instead of ==#15355dk2k wants to merge 1 commit intoopensearch-project:mainfrom
dk2k wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Contributor
|
❌ Gradle check result for 878963d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Member
|
Looks good. Would be nice to have a spotless rule for these and fix any other instances of it. Please amend your PR for DCO with |
This was referenced Sep 6, 2024
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.