Make ThreadContext.stashAndMergeHeaders package-private#14983
Make ThreadContext.stashAndMergeHeaders package-private#14983cwperks wants to merge 3 commits intoopensearch-project:mainfrom
ThreadContext.stashAndMergeHeaders package-private#14983Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
❌ Gradle check result for 56bebf6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for fadc5fe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for fadc5fe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for fadc5fe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14983 +/- ##
============================================
+ Coverage 71.78% 71.81% +0.03%
- Complexity 62694 62728 +34
============================================
Files 5160 5162 +2
Lines 294211 294364 +153
Branches 42553 42577 +24
============================================
+ Hits 211212 211411 +199
+ Misses 65599 65568 -31
+ Partials 17400 17385 -15 ☔ View full report in Codecov by Sentry. |
ThreadContext.stashAndMergeHeaders package-private
|
Closing in favor of #15039 |
Description
The ThreadContext class overly exposes many methods as public. Currently,
stashAndMergeHeadersis publicly exposed, but its only usage is in testing. This PR changes the access modifier on this method to package-private to prevent this internally used method from being exposed publicly.Related Issues
Related to #14931
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.