fix visitor pattern by calling visit instead of accept#13837
fix visitor pattern by calling visit instead of accept#13837wdongyu wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
|
❌ Gradle check result for 1c3b788: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
|
@wdongyu Thanks for your work, please amend your commit to include sign-off, so that the DOC check can pass, and also add a change log for this. |
|
❌ Gradle check result for c7b1d71: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
c7b1d71 to
595ffb0
Compare
|
@gaobinlong sorry for the late response, I have pushed the latest commit |
This comment was marked as resolved.
This comment was marked as resolved.
|
❌ Gradle check result for 595ffb0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: wangdongyu.danny <wangdongyu.danny@bytedance.com>
Signed-off-by: wangdongyu.danny <wangdongyu.danny@bytedance.com>
595ffb0 to
07b1505
Compare
|
❌ Gradle check result for 07b1505: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
Description
This PR aims to fix some bugs of the visitor pattern implemented before in this PR. It should go down the tree by calling the
visitmethods of nested sub QueryBuilders, theacceptshould happen in sub QueryBuilders.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#13812
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.