Refactor constant string and fix log message

dbwiddis · dbwiddis · commit 7d2beca8bfac · 2022-08-26T09:19:29.000-07:00
Signed-off-by: Daniel Widdis &lt;widdis@gmail.com&gt;
diff --git a/server/src/main/java/org/opensearch/extensions/rest/RestSendToExtensionAction.java b/server/src/main/java/org/opensearch/extensions/rest/RestSendToExtensionAction.java
@@ -36,6 +36,7 @@
  */
 public class RestSendToExtensionAction extends BaseRestHandler {
 
+    private static final String SEND_TO_EXTENSION_ACTION = "send_to_extension_action";
     private static final Logger logger = LogManager.getLogger(RestSendToExtensionAction.class);
 
     private final List<Route> routes;
@@ -77,7 +78,7 @@ public RestSendToExtensionAction(
 
     @Override
     public String getName() {
-        return "send_to_extension_action";
+        return SEND_TO_EXTENSION_ACTION;
     }
 
     @Override
@@ -129,7 +130,7 @@ public String executor() {
                     restExecuteOnExtensionResponseHandler
                 );
             } catch (Exception e) {
-                logger.info("Failed to send Register REST Actions request to OpenSearch", e);
+                logger.info("Failed to send REST Actions to extension " + discoveryExtension.getName(), e);
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@`
`36`	`36`	`*/`
`37`	`37`	`public class RestSendToExtensionAction extends BaseRestHandler {`
`38`	`38`
	`39`	`+ private static final String SEND_TO_EXTENSION_ACTION = "send_to_extension_action";`
`39`	`40`	`private static final Logger logger = LogManager.getLogger(RestSendToExtensionAction.class);`
`40`	`41`
`41`	`42`	`private final List<Route> routes;`
`@@ -77,7 +78,7 @@ public RestSendToExtensionAction(`
`77`	`78`
`78`	`79`	`@Override`
`79`	`80`	`public String getName() {`
`80`		`- return "send_to_extension_action";`
	`81`	`+ return SEND_TO_EXTENSION_ACTION;`
`81`	`82`	`}`
`82`	`83`
`83`	`84`	`@Override`
`@@ -129,7 +130,7 @@ public String executor() {`
`129`	`130`	`restExecuteOnExtensionResponseHandler`
`130`	`131`	`);`
`131`	`132`	`} catch (Exception e) {`
`132`		`- logger.info("Failed to send Register REST Actions request to OpenSearch", e);`
	`133`	`+ logger.info("Failed to send REST Actions to extension " + discoveryExtension.getName(), e);`
`133`	`134`	`}`
`134`	`135`	`}`
`135`	`136`	`}`