Added two unit tests for the decimals fix. testStarTreeDocValuesWithDecimals validates the behavior of the StarTree index when it works with decimal values (both double and float types). testStarTreeDocValuesDecimalPrecision validates that the StarTree index maintains decimal precision, particularly with high precision values like 10.9999 for double and 99.999f for float.

DanielSLDev · DanielSLDev · commit 264a58cb9d51 · 2025-02-19T11:43:13.000-07:00
Signed-off-by: Daniel Salas &lt;daniel.salas@encora.com&gt;
diff --git a/server/src/main/java/org/opensearch/search/startree/filter/provider/DimensionFilterMapper.java b/server/src/main/java/org/opensearch/search/startree/filter/provider/DimensionFilterMapper.java
@@ -161,14 +161,14 @@ public DimensionFilter getRangeMatchFilter(
         Long parsedLow = rawLow == null ? defaultMinimum() : numberFieldType.numberType().parse(rawLow, true).longValue();
         Long parsedHigh = rawHigh == null ? defaultMaximum() : numberFieldType.numberType().parse(rawHigh, true).longValue();
 
-        boolean lowerTermHasDecimalPart = hasDecimalPart(rawLow);
+        boolean lowerTermHasDecimalPart = hasDecimalPart(parsedLow);
         if ((lowerTermHasDecimalPart == false && includeLow == false) || (lowerTermHasDecimalPart && signum(parsedLow) > 0)) {
             if (parsedLow.equals(defaultMaximum())) {
                 return new MatchNoneFilter();
             }
             ++parsedLow;
         }
-        boolean upperTermHasDecimalPart = hasDecimalPart(rawHigh);
+        boolean upperTermHasDecimalPart = hasDecimalPart(parsedHigh);
         if ((upperTermHasDecimalPart == false && includeHigh == false) || (upperTermHasDecimalPart && signum(parsedHigh) < 0)) {
             if (parsedHigh.equals(defaultMinimum())) {
                 return new MatchNoneFilter();
diff --git a/server/src/test/java/org/opensearch/search/aggregations/startree/MetricAggregatorTests.java b/server/src/test/java/org/opensearch/search/aggregations/startree/MetricAggregatorTests.java
@@ -168,6 +168,47 @@ public void testStarTreeDocValues() throws IOException {
         }
     }
 
+    public void testStarTreeDocValuesWithDecimals() throws IOException {
+        final List<DimensionFieldData> dimensionFieldDatum = List.of(
+            new DimensionFieldData("double_field", () -> 10.75, DimensionTypes.DOUBLE),
+            new DimensionFieldData("float_field", () -> 5.25f, DimensionTypes.FLOAT)
+        );
+        testStarTreeDocValuesInternal(
+            getCodec(() -> 10,
+                dimensionFieldDatum.stream().collect(
+                    Collectors.toMap(
+                        df -> df.getDimension().getField(),
+                        DimensionFieldData::getFieldType,
+                        (v1, v2) -> v1,
+                        LinkedHashMap::new
+                    )
+                ),
+                StarTreeFilterTests.METRIC_TYPE_MAP
+            ),
+            dimensionFieldDatum
+        );
+    }
+    public void testStarTreeDocValuesDecimalPrecision() throws IOException {
+        final List<DimensionFieldData> dimensionFieldDatum = List.of(
+            new DimensionFieldData("double_field", () -> 10.9999, DimensionTypes.DOUBLE),
+            new DimensionFieldData("float_field", () -> 99.999f, DimensionTypes.FLOAT)
+        );
+        testStarTreeDocValuesInternal(
+            getCodec(() -> 50,
+                dimensionFieldDatum.stream().collect(
+                    Collectors.toMap(
+                        df -> df.getDimension().getField(),
+                        DimensionFieldData::getFieldType,
+                        (v1, v2) -> v1,
+                        LinkedHashMap::new
+                    )
+                ),
+                StarTreeFilterTests.METRIC_TYPE_MAP
+            ),
+            dimensionFieldDatum
+        );
+    }
+
     private void testStarTreeDocValuesInternal(Codec codec, List<DimensionFieldData> dimensionFieldData) throws IOException {
         Directory directory = newDirectory();
         IndexWriterConfig conf = newIndexWriterConfig(null);
