Segment Replication - Add additional unit tests for update & delete ops. (#4237)

mch2 · Rishikesh1159 · commit 0d208f0a35e5 · 2022-08-17T10:15:39.000Z
* Segment Replication - Add additional unit tests for update &amp; delete operations.

Signed-off-by: Marc Handalian &lt;handalm@amazon.com&gt;

* Fix spotless.

Signed-off-by: Marc Handalian &lt;handalm@amazon.com&gt;

Signed-off-by: Marc Handalian &lt;handalm@amazon.com&gt;
diff --git a/server/src/test/java/org/opensearch/index/shard/SegmentReplicationIndexShardTests.java b/server/src/test/java/org/opensearch/index/shard/SegmentReplicationIndexShardTests.java
@@ -8,17 +8,23 @@
 
 package org.opensearch.index.shard;
 
+import org.opensearch.action.delete.DeleteRequest;
+import org.opensearch.action.index.IndexRequest;
 import org.opensearch.cluster.metadata.IndexMetadata;
 import org.opensearch.common.settings.Settings;
 import org.opensearch.common.unit.TimeValue;
+import org.opensearch.common.xcontent.XContentType;
 import org.opensearch.index.IndexSettings;
+import org.opensearch.index.engine.DocIdSeqNoAndSource;
 import org.opensearch.index.engine.NRTReplicationEngineFactory;
+import org.opensearch.index.mapper.MapperService;
 import org.opensearch.index.replication.OpenSearchIndexLevelReplicationTestCase;
 import org.opensearch.indices.replication.checkpoint.SegmentReplicationCheckpointPublisher;
 import org.opensearch.indices.replication.checkpoint.ReplicationCheckpoint;
 import org.opensearch.indices.replication.common.ReplicationType;
 
 import java.io.IOException;
+import java.util.List;
 
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.verify;
@@ -52,6 +58,54 @@ public void testReplicationCheckpointNotNullForSegReb() throws IOException {
         closeShards(indexShard);
     }
 
+    public void testSegmentReplication_Index_Update_Delete() throws Exception {
+        String mappings = "{ \"" + MapperService.SINGLE_MAPPING_NAME + "\": { \"properties\": { \"foo\": { \"type\": \"keyword\"} }}}";
+        try (ReplicationGroup shards = createGroup(2, settings, mappings, new NRTReplicationEngineFactory())) {
+            shards.startAll();
+            final IndexShard primaryShard = shards.getPrimary();
+
+            final int numDocs = randomIntBetween(100, 200);
+            for (int i = 0; i < numDocs; i++) {
+                shards.index(new IndexRequest(index.getName()).id(String.valueOf(i)).source("{\"foo\": \"bar\"}", XContentType.JSON));
+            }
+
+            primaryShard.refresh("Test");
+            replicateSegments(primaryShard, shards.getReplicas());
+
+            shards.assertAllEqual(numDocs);
+
+            for (int i = 0; i < numDocs; i++) {
+                // randomly update docs.
+                if (randomBoolean()) {
+                    shards.index(
+                        new IndexRequest(index.getName()).id(String.valueOf(i)).source("{ \"foo\" : \"baz\" }", XContentType.JSON)
+                    );
+                }
+            }
+
+            primaryShard.refresh("Test");
+            replicateSegments(primaryShard, shards.getReplicas());
+            shards.assertAllEqual(numDocs);
+
+            final List<DocIdSeqNoAndSource> docs = getDocIdAndSeqNos(primaryShard);
+            for (IndexShard shard : shards.getReplicas()) {
+                assertEquals(getDocIdAndSeqNos(shard), docs);
+            }
+            for (int i = 0; i < numDocs; i++) {
+                // randomly delete.
+                if (randomBoolean()) {
+                    shards.delete(new DeleteRequest(index.getName()).id(String.valueOf(i)));
+                }
+            }
+            primaryShard.refresh("Test");
+            replicateSegments(primaryShard, shards.getReplicas());
+            final List<DocIdSeqNoAndSource> docsAfterDelete = getDocIdAndSeqNos(primaryShard);
+            for (IndexShard shard : shards.getReplicas()) {
+                assertEquals(getDocIdAndSeqNos(shard), docsAfterDelete);
+            }
+        }
+    }
+
     public void testIgnoreShardIdle() throws Exception {
         try (ReplicationGroup shards = createGroup(1, settings, new NRTReplicationEngineFactory())) {
             shards.startAll();
diff --git a/test/framework/src/main/java/org/opensearch/index/replication/OpenSearchIndexLevelReplicationTestCase.java b/test/framework/src/main/java/org/opensearch/index/replication/OpenSearchIndexLevelReplicationTestCase.java
@@ -141,7 +141,12 @@ protected ReplicationGroup createGroup(int replicas, Settings settings) throws I
     }
 
     protected ReplicationGroup createGroup(int replicas, Settings settings, EngineFactory engineFactory) throws IOException {
-        IndexMetadata metadata = buildIndexMetadata(replicas, settings, indexMapping);
+        return createGroup(replicas, settings, indexMapping, engineFactory);
+    }
+
+    protected ReplicationGroup createGroup(int replicas, Settings settings, String mappings, EngineFactory engineFactory)
+        throws IOException {
+        IndexMetadata metadata = buildIndexMetadata(replicas, settings, mappings);
         return new ReplicationGroup(metadata) {
             @Override
             protected EngineFactory getEngineFactory(ShardRouting routing) {
