Skip to content

Update OpenSearch LicenseHeaders to use the short version#29

Merged
dblock merged 2 commits intoopensearch-project:mainfrom
peterzhuamazon:opensearch-license-headers
Aug 13, 2021
Merged

Update OpenSearch LicenseHeaders to use the short version#29
dblock merged 2 commits intoopensearch-project:mainfrom
peterzhuamazon:opensearch-license-headers

Conversation

@peterzhuamazon
Copy link
Copy Markdown
Member

@peterzhuamazon peterzhuamazon commented Aug 12, 2021 •
edited
Loading

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Update OpenSearch LicenseHeaders to use the short version.

  • It removes the Amazon related info and change to OpenSearch Contributors for copyrights.
  • It also changed to a short version which is cleaner and still has enough information.

Issues Resolved

#21

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Update OpenSearch LicenseHeaders to use the short version
2f93908 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon force-pushed the opensearch-license-headers branch from 85b6993 to 2f93908 Compare August 12, 2021 19:21
@peterzhuamazon peterzhuamazon changed the title Update OpenSearch LicenseHeaders Update OpenSearch LicenseHeaders to use the short version Aug 12, 2021
@dblock dblock mentioned this pull request Aug 12, 2021
Merged
1 task
@dblock
Copy link
Copy Markdown
Member

dblock commented Aug 12, 2021

Is the short version the preferred version, @hyandell?

@hyandell
Copy link
Copy Markdown
Contributor

hyandell commented Aug 12, 2021

Yes, that's the preferred version.

In the text however, I would say this:

New files in your code contributions should contain the following license header. If you are modifying existing files with license headers, or including new files that already have license headers, do not remove or modify them without guidance.

@peterzhuamazon
Adding new header summary text per Henri suggestions
56dc8d9 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Copy Markdown
Member Author

peterzhuamazon commented Aug 12, 2021

@hyandell Please check again I updated the text based on your suggestions.

@peterzhuamazon
Copy link
Copy Markdown
Member Author

peterzhuamazon commented Aug 12, 2021

Thanks @hyandell for approval @dblock please merge it. Thanks.

@dblock dblock merged commit d32533a into opensearch-project:main Aug 13, 2021
@peterzhuamazon peterzhuamazon deleted the opensearch-license-headers branch August 13, 2021 17:21
@peterzhuamazon peterzhuamazon mentioned this pull request Aug 13, 2021
Merged
1 task
@dblock dblock mentioned this pull request Aug 13, 2021
Closed
32 tasks
@dbwiddis dbwiddis mentioned this pull request Oct 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hyandell hyandell hyandell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hyandell hyandell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterzhuamazon @dblock @hyandell