Skip to content

[META] Baseline MAINTAINERS, CODEOWNERS and external collaborator permissions #125

@dblock

Description

@dblock

What/Why

What are you proposing?

There are some common differences across repos in opensearch-project when it comes to maintainers, codeowners and repository permissions.

  1. The MAINTAINERS.md list is not the folks actively engaged in a project.
  2. PRs get approved by folks that are not in the MAINTAINERS list, because permissions aren't in sync.
  3. CODEOWNERS doesn't exist, so maintainers don't always get properly notified about pull requests or their list doesn't appear in reviewers when contributors make pull requests.
  4. CODEOWNERS is out of sync, and does not include a subset, or all maintainers.
  5. Actual repository permissions may not include folks in MAINTAINERS as external collaborators.
  6. Repo permissions may give some groups access to more repos than they are a member of.

The proposal is to correct and align on all the issues above in a single campaign.

What problems are you trying to solve?

  • Collaborators in opensearch-project expect transparency in who maintainers on any of the projects are.
  • Maintainers want to be notified (or have the option not to be notified) when PRs are opened.
  • Maintainers need reliable lists to find other maintainers to be able to follow our process of adding new maintainers.
  • Maintainers want to be publicly recognized for their work.

What will it take to execute?

First, baseline MAINTAINERS if you've never done that.

  1. Email/reach out to current maintainers and ask them whether they want to still be a maintainer.
  2. Check the list of people in MAINTAINERS.md to include only active maintainers.
  3. Add/move non-active maintainers to an emeritus section.
  4. Add active maintainers to CODEOWNERS.
  5. Remove any broad teams from CODEOWNERS.
  6. Make a PR with the changes above, make sure CODEOWNERS is green.
  7. Once the PR is approved, ask an org admin or an admin delegate (e.g. @bbarani) to sync the repo permissions, removing groups and adding individual contributors. Let's promote some new folks to this role to help, too.
  8. Merge the PR.
  9. Maintain the MAINTAINERS.md and CODEOWNERS.md accurate.

Verified

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions