Remove call to nonexistent member seekpos() of std::fpos in VS 15.8#569
Merged
openscenegraph merged 1 commit intoopenscenegraph:masterfrom Jun 28, 2018
Merged
Conversation
…ersion 15.8 or later
Owner
|
Thanks for the revision Larry :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove call to nonexistent member seekpos() of std::fpos in VS 2017 version 15.8. It has removed in our curent latest published release VS 15.8 preview 3(_MSC_VER=1915). So it failed with below issue：
error C2039: 'seekpos': is not a member of 'std::fpos<_Mbstatet>'
See http://eel.is/c++draft/fpos -- to get to an offset you can convert to int; now there is no seekpos member in VS15.8.
We have fixed this issue in vcpkg (microsoft/vcpkg#3753).
The previous PR that we discussed here: #567
I send the new one, please help approve. Thanks!