Stop reverting prior changes by simply cancelling the "Save design info" dialog. Fixes #2680 #2815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d from RocketComponentConfig.java. The removed code was causing misbehavior from an unrelated preference setting (former lines 61-73 of SaveDesignInfoPanel) and causing spurious document.undo() actions upon dialog cancel (former line 81): there should be nothing to undo re: the SaveDesignInfoPanel. This resolves openrocket#2680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed code from SaveDesignInfoPanel.java which was apparently pasted from RocketComponentConfig.java. The removed code was causing misbehavior from an unrelated preference setting (former lines 61-73 of
SaveDesignInfoPanel) and causing spuriousdocument.undo()actions upon dialog cancel (former line 81): there should be nothing to undo re: theSaveDesignInfoPanel. This resolves #2680