[#2776] Include super-parent angles in instance rotation #2780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2776. The issue was not just a simple rendering glitch, but a more fundamental issue, namely that rocket component locations (the return value of
getComponentLocations()inRocketComponent) did not account for rotations of super-parents. For example, take this structure:Conditions:
With a total rotation of -180°, you would expect the 10 cm offset to cause the body tube to move 10 cm in the negative y direction. However, it was moving 10 cm in the negative z direction, because only the -90° rotation of Pod Set 2 was taken into account in the pod set instance locations.
A very extreme example with a double-nested pod set:

After this PR:
