Get rid of 10 m/s wind speed and 11km wind level limits #2771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this works analogously to some of the component configuration editors: You can only use the slider to get up to 10 m/s, but you can enter any positive value in the text field.
Contributor
|
That sounds perfect for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 10 m/s max wind speed probably came from the NAR, TRA, and UKRA safety code limits of 20 mph max ground wind; it doesn't apply at higher altitudes where the winds are pretty much always higher than that, and we also shouldn't be preventing a user from setting whatever they want.
Note that the slider for the average wind speed now works analogously to the sliders in some of the component configuration dialogs: you can only use the slider to set the wind speed up to 10 m/s, but you can enter any speed you want by typing it in.
There should be a warning that the wind speed exceeds safety codes; I'll make an issue for that so we don't forget it, but I'd rather wait to add it until the upcoming Warning rewrite.
The Extended ISA atmosphere model prohibits setting a launch site above 11km (the limit of the troposphere); the reason for that isn't clear to me, but anything that high isn't realistic anyway. Though the launch site height is limited, the model allows flights above that. This PR leaves the limit on max launch altitude, but allows arbitrary altitudes for the wind levels.
Fixes #2767