Skip to content

Conversation

@JoePfeiffer
Copy link
Contributor

This PR makes all warnings look like
Problem: "component", "component"
both for uniformity and for clarity. Also properly sets zero-volume body tube priority.

Fixes #2669

@neilweinstock
Copy link
Contributor

Does it "fix" the "special" warnings as well (e.g. Large AOA, high deployment speed)?

@JoePfeiffer
Copy link
Contributor Author

Does it "fix" the "special" warnings as well (e.g. Large AOA, high deployment speed)?

No, I started down that rabbit hole but decided to just fix the big one. I actually think the large AOA warning is OK; it gives the warning and then the angle of attack in parentheses. There is no component displayed since it's the whole rocket.

Actually, since it doesn't throw that warning any more when the rocket is about to tumble I'm not sure it's even possible to trigger it! I was able to do it before by setting a really high wind speed, but the wind speed seems to be capped at 10 m/s now.

But hmmm, there may be something to do with the high speed deployment...

@JoePfeiffer JoePfeiffer marked this pull request as draft January 17, 2025 15:35
@neilweinstock
Copy link
Contributor

neilweinstock commented Jan 17, 2025

Actually, since it doesn't throw that warning any more when the rocket is about to tumble I'm not sure it's even possible to trigger it! I was able to do it before by setting a really high wind speed, but the wind speed seems to be capped at 10 m/s now.

I was able to trigger it in the same way, with a high wind and low-powered motor. It's not easy, and probably low priority. And as you say it probably doesn't strictly need any changes right now anyway.

But hmmm, there may be something to do with the high speed deployment...

It would definitely be helpful to identify the component for that one.

@JoePfeiffer JoePfeiffer marked this pull request as ready for review January 17, 2025 16:35
@neilweinstock
Copy link
Contributor

Looks good to me.

@JoePfeiffer JoePfeiffer merged commit 5d9cf72 into openrocket:unstable Jan 20, 2025
1 check passed
@JoePfeiffer JoePfeiffer deleted the fix-2669 branch March 10, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Zero volume body" warning shows incorrectly

2 participants