Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Nov 25, 2023

This PR fixes #2338 by performing a well-needed UI enhancement of the x- and y-axis flight data type selectors.

The current UI is a way-too-long list of all the available items:
image

This PR categorizes all the data types into dedicated groups. Even more useful, there's also a search field where you can type the desired data type.

Demo:

Screen.Recording.2023-11-25.at.03.01.16.mp4

How it works:

  • When no text is entered in the search box, the items are displayed in their group.
  • When the search field is used, the popup switches from the category display to a search display. The search display lists all the data types that match the search word. The matching text is underlined. If you click on one of the items in the list, it will be selected.
  • When typing a search word, the first filtered item will be highlighted. If you press the "Enter" key, you will select the highlighted item.
  • You can change the highlighted item by using the up/left and down/right arrow keys. Pressing the "Enter" key selects the highlighted item.

I wrote the custom combobox UI in a new, general widget, called SearchableAndCategorizableComboBox (long name, I know), so it can be used in other parts of the UI if we wanted to. I feel like there may be other areas of OpenRocket where this could be useful.

@neilweinstock
Copy link
Contributor

That is beautiful. Big improvement.

@JoePfeiffer
Copy link
Contributor

Wow. Just wow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Organize sim plot y axis types selection box

3 participants