-
-
Notifications
You must be signed in to change notification settings - Fork 531
[#2079] Display secondary stability unit #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Two things:
|
|
|
|
Another alternative: instead of the parentheses, display like this: "2.0 cal / 15 %" This way, neither is really primary or secondary. You always show both, and remove the preference entirely. |
|
OK, I yield. Let's have a primary and secondary preference, as you suggested. There should be an option on secondary to disable it, if reasonably possible. I am thinking that slash-separating the two values might be better than putting the second one in parens. What do you think? |
One possibility is to disable the secondary unit when it is the same as the primary unit, but that is probably not straight-forward to users. Probably better to add a checkbox under the secondary stability unit preference. I would actually implement both; hide the secondary unit when the checkbox is unchecked in the preferences or the primary and secondary unit are equal.
When using the secondary preference idea, we should indeed use a slash. |
That sounds perfect. |
|
Functions as described, with no anomalous behavior found. OR Build: 1761 |
Yes, will break compatibility, but it's just one checkbox. Too bad.
|
Secondary stability unit can now be chosen in the preferences + can be disabled. Screen.Recording.2023-05-29.at.15.24.52.mp4 |
|
Looks great. |
|
Very nice. OR Build: 1765 |
This PR fixes #2079 and adds the stability in percentage length in addition to the stability value in the currently selected stability unit. If the selected unit is already the percentage, or the stability value is N/A, the stability percentage is not included.
Screen.Recording.2023-05-24.at.01.43.07.mp4