[#2055] Add motor manufacturers substitutor #2057
Conversation
|
Cool. Did anything like this exist before? If so I had no idea (and, most likely, neither does anyone else). |
The {motors} tag always existed. If you edit the config name in OR 22.02, you can see the tag. |
|
Functions as expected, no anomalous behavior found. Although it would be nice if the display could be [A8-5 Estes; B6-0 Estes; B6-0 Estes] instead of [A8-5; B6-0; B6-0 Estes; Estes; Estes] OR Build: 1552 |
That would require a new tag IMO, like |
I would tend to think that this is the desired behavior. Not sure if the Discord user who made the initial request specified? |
He specified it as is implemented in this PR. |
|
OK, fair enough, although I wonder how many other people will actually want it to work this way (doesn't make a great deal of sense to me). |
Agreed. Yes, I can see this is what was requested, but @neilweinstock 's suggestion would make more sense to me as well. |
|
Okay, I changed the substitutor to a generalized one, where you can also use a combination of motors and manufacturers, as described in #2068. Substitution of New rename dialog: |
|
Now we're talking. :) I would suggest that the example for the combination should be {motors manufacturers} which would yield something like "Aerotech M1350-0" which is (I think) the most likely desired output. |
Okay, I'll change it. I was trying to demonstrate that you can choose the separator between the tags. Should I add an extra info text, e.g. "A combination of the above can be used. You may choose the separator between the tags."? |
|
More show, less tell is generally preferable. In this case, it is a feature that will be used by an incredibly small group of people; the number who care about separators is an even smaller subset. I wouldn't worry about it. |
|
I apologize but I fumbled my original suggestion... I meant to say {manufacturers motors} which would yield "Estes D12". Not sure why the substitutors are plural but not worth worrying about. |
Sorry, didn't read your message properly, updated now. I decided on the plural form because |
|
If we're stuck with motors then make it manufacturers for consistency. In a perfect world it would be motor and manufacturer. Oh well! |
|
Very nice. OR Build: 1564 |
This PR fixes #2055. Entering
{manufacturers}in the configuration name field now replaces that text with the motor manufacturers.I also noticed that the configurations in the flight configuration combo box did not use the proper RocketDescriptor substitutor. In layman terms, this means that the text in the flight configuration combo box was different from that seen in the motors configurations table. This was only noticeable when there were no motors in the configuration. In that case, the flight configuration displayed
No motors, while the motors configuration table displayed[No motors](with brackets).This PR now ensures that the configurations in the flight configuration combo box are properly formatted. The only noticeable difference with the current behavior is that a "No motors" configuration is now displayed as
[No motors]instead ofNo motors.Screen.Recording.2023-02-14.at.13.51.38.mp4
I also added an explanation of the substitution tags in the rename config dialog:
