Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Feb 12, 2023

This PR fixes #2035 and adds instances options to launch lugs. Apparently all the code for launch lug instances was already programmed, but the instances settings were just not present in the launch lug config dialog. (Or maybe it was once, but got deleted 👀).

Note: this PR is a subbranch of #2034, so merge that first before merging this PR.

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Feb 12, 2023

No anomalous behavior found.

Upon increasing the instance count, I expected to see two separate launch lugs, but only saw one (the first completely overlapping the first). I suggest a default initial instance separation value equal to that of the rail button default initial instance separation value, rather than a default initial instance separation value of zero.

OR Build: 1532
Microsoft Windows 11 Pro; 10.0.22621 Build 22621.1105; Windows Feature Experience Pack 1000.22638.1000.0
Java(TM) SE Runtime Environment 18.9 (build 11.0.18+9-LTS-195)

@SiboVG
Copy link
Member Author

SiboVG commented Feb 12, 2023

Upon increasing the instance count, I expected to see two separate launch lugs, but only saw one (the first completely overlapping the first). I suggest a default initial instance separation value equal to that of the rail button default initial instance separation value, rather than a default initial instance separation value of zero.

Good call, fixed now. Default separation is now 2x the launch lug length

@SiboVG SiboVG merged commit 65903bd into openrocket:unstable Feb 14, 2023
@SiboVG SiboVG deleted the issue-2035 branch February 14, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add instance settings for launch lugs

2 participants