-
-
Notifications
You must be signed in to change notification settings - Fork 533
[#1643] Round motor filter panel diameter labels #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As to the issue reported, functions as expected, no anomalies found. As long as the issue of motor diameter units is being considered, the unit "meters" either needs to be disallowed or its decimal placement adjusted by two places. My preference would be disallowed. This issue, or a new issue? Build 1004 |
Hm... for now I would leave it as it, but I'm wondering why the hell there are even 2 types of limit sliders? The slider for the diameter limiting and length limiting is different. I actually like that the length limit slider has explicit text boxes to set the limit values, is also useful for your mentioned case for meter units, so that it's clear what the limit values are even though the labels say '0'. Now there's the choice: do we add tick labels for both the length and diameter limit sliders, or do we remove the tick labels all together, for the diameter limit slider? |
|
Although I regularly use the diameter slider and its tick marks with labels, I must admit, I have never found a need to use the length slider. Comparing the two, however, there is one stark difference, motors have specific fixed diameters, and having the slider snap to those diameters is very helpful. On the other hand, there is no fixed length for a motor mount, the tube is whatever length the builder chooses (or has lying around), and a snap feature is not needed or probably even desired. Against this backdrop, it would probably be helpful to some users to have the tick marks on the length slider labeled with a length measurement, but (as is currently) without the snap; I would prefer that the diameter tick marks and labels remain. |
That said, I don't think I've ever checked the "limit to motor mount length" box. For small motors I'll typically have a motor block in there that limits the motor length to something shorter than the motor mount, and larger motors typically extend out the top of the motor mount tube.
Not only that, but the motor may not even match the length of the mount (see my comment above). So a snap really doesn't make sense.
|
|
Functions as expected, no anomalies found. Build 1038 |
|
Functions as expected, no anomalies found. Build 1041 |



This PR fixes #1643 and unit rounds the diameter labels.