[#1653] Scale RadiusRingComponent according to scale direction #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Functions as expected, no anomalies found. Build 1001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1653. The problem was the order of scaling. The previous behavior was that first the outer radius of the ring was scaled, and then the inner ring. This works for scaling up, but if scaled down, the outer radius would first scale down, would then become smaller than the inner radius, so the inner radius got clipped, and then the clipped inner radius got scaled down again. This PR changes the scaling order based on when you're scaling up or down. If scaled up, first the outer radius is scaled and then the inner radius, when scaling down, first the inner radius is scaled, and then the outer radius.