Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Jul 25, 2022

This PR fixes #1552 and allows to traverse the simulation table by pressing the tab, right arrow or down arrow key to go to the next row in the sim table, and shift-tab, left arrow or up arrow to go to the previous row in the sim table.

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Jul 27, 2022

In the motors, recovery and stage configuration tables, when you use the tab key to parse through the fields, pressing the tab key when in the last field takes you to the first field. Likewise, when using shift+tab to reverse the direction, shift+tab in the first field takes you to tha last field.

The simulation table does not function this way. A shift+tab in the first field leaves you in that field, and a tab in the last field leaves you in that field.

Should the former behavior be consistent across all of the tables, including the simulation table?

Build 831
[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

@SiboVG
Copy link
Member Author

SiboVG commented Jul 27, 2022

In the motors, recovery and stage configuration tables, when you use the tab key to parse through the fields, pressing the tab key when in the last field takes you to the first field. Likewise, when using shift+tab to reverse the direction, shift+tab in the first field takes you to tha last field.

The simulation table does not function this way. A shift+tab in the first field leaves you in that field, and a tab in the last field leaves you in that field.

Should the former behavior be consistent across all of the tables, including the simulation table?

Good point, wasn't aware that the tab key had that effect in the other tables. I would keep it consistent. I'll push a fix for it soon.

@SiboVG
Copy link
Member Author

SiboVG commented Jul 27, 2022

I'll push a fix for it soon.

'Soon' has passed.

@SiboVG SiboVG merged commit 04409e5 into openrocket:unstable Aug 2, 2022
@SiboVG SiboVG deleted the issue-1552 branch August 2, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Parse through simulation table using tab key and up/down arrow key

2 participants