-
-
Notifications
You must be signed in to change notification settings - Fork 533
[#1549] Ctrl/Cmd + A select all shortcut in simulation table and component tree #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes the bug of the text for edit, delete and duplicate button to become smaller
|
When I just tried this, it only selected them all after I had selected one. If I started with none selected, cmd-A didn't do anything. |
You first need to put focus on the simulation table. If you simply switch to the simulation tab, the simulation table is not focused (you can actually see the blue outline around the 'New simulation' button, so that button has focus). |
|
How do I give it focus without selecting an existing sim? Clicking in the blank part of the list area doesn't do it. |
|
Testing results, using A simple model rocket example. There are two behaviors, the first of which is expected, the second of which is not. Action One (Expected Behavior)
Action Two (Unexpected Behavior)
No other unexpected behaviors found. Build 826 |
You can't, you can only do so by selecting a sim (the same is true for the motors, recovery and stage configuration table). |
Hm well this issue isn't really inherent to the implementation of this PR... The same behavior holds in the motors, recovery and stage config tables. E.g. the motors config: select a config, hit ctrl + A, selects all configs, select an individual config again and click 'reset deployment', and then hit ctrl + A again, nothing happens. On macOS you can also see that Java Swing make a visual distinction between a row being selected and in focus and a row being selected, but not in focus (because the focus was lost after clicking 'reset deployment'). See video below. Screen.Recording.2022-07-23.at.22.13.16.movSo I would create a new issue to restore the focus to the motors, recovery, stage and simulation table after a certain action has been performed. That will fix the issue you described. |
|
As described by @SiboVG above, this PR functions as expected with no anomalies found. Build 826 |
That is hilariously subtle. |
This PR fixes #1549 and allows all elements of the simulation table to be selected with the ctrl/cmd + A command. The same shortcut also works in the component tree, where all components are selected, except for the rocket.
I also noticed a bug in the simulation table where if you select e.g. row 1, then row 2, the plot button was disabled, as should be, but if you would then deselect row 1, then the button's status did not re-enable. This is fixed now in this PR. I also disabled the 'Edit simulation' when multiple simulations are selected. The 'plot' and 'edit' context menu items are now also disabled when multiple simulations are selected.
While working on the previous bug, I also noticed that the 'Edit', 'Delete' and 'Duplicate' button in the home screen (next to the component tree) had a smaller text than the move up/down buttons above. I think this was only macOS specific, but in any case this PR fixes that.