Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Jul 18, 2022

This PR fixes #1537 by adding the following configuration parameters for a rail button:

  • Inner diameter (controls the diameter of the middle part of the rail button)
  • Base height (controls the height of the cylinder closest to its parent component)
  • Flange height (controls the height of the cylinder furthest away from its parent component)

Demo:

Screen.Recording.2022-07-19.at.00.54.43.mp4

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Jul 18, 2022

It works welll, but two comments.

  1. Where Total Height cannot be less than Base Height + Flange Height, I suggest placing the Total Height fields below the Flange Height fields.

Rail Button Component Rev_01

I believe this will flow better with those using the tab key to change fields, as well as prevent the potential confusion caused by the substitution of a user entered value with incorrect (yet to be entered) Base Height + Flange Height.

  1. Where there are three basic profiles for rail buttons...

Rail Button Component Rev_03

I suggest adding a ScrewHeight field as part of this PR so that all three profiles will be addressed. Functionally, the display height of the rail button would equal Height + Screw Height, and the displayed flange height would equal Flange Height + ScrewHeight.

Otherwise, an issue to add the ScrewHeight field can be opened.

@SiboVG
Copy link
Member Author

SiboVG commented Jul 18, 2022

2. Where there are three basic profiles for rail buttons...

Rail Button Component Rev_03

I suggest adding a ScrewHeight field as part of this PR so that all three profiles will be addressed. Functionally, the display height of the rail button would equal Height + Screw Height, and the displayed flange height would equal Flange Height + ScrewHeight.

Otherwise, an issue to add the ScrewHeight field can be opened.

Hm, I'm a bit opposed to adding configuration options for something that the user will not get to see. I'm happy to add the screw height parameter, but only if there is some sort of dropdown menu added to the rail button configuration panel that lets you switch between one of those 3 rail button types. In that case, the rocket view would/should change the rail button's display to match your drawing, and the user would actually see what changing the screw height is doing. For that, I would create a new issue.

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Jul 19, 2022

I'm a bit opposed to adding configuration options for something that the user will not get to see.

I agree, the above was the math behind it. From a display standpoint, this is what I am proposing (side view).

Rail Button Component Rev_04

The user would be able to set the screw height, but the diameter of the screw head would be OuterDiameter. There would be no need for the complexity of a drop down to implement this, just the ScrewHeight field.

What I was thinking...

@SiboVG
Copy link
Member Author

SiboVG commented Jul 29, 2022

The user would be able to set the screw height, but the diameter of the screw head would be OuterDiameter. There would be no need for the complexity of a drop down to implement this, just the ScrewHeight field.

Fair enough. But I won't be including the screwHeight as a parameter for this PR, since that would involve adding visuals for the screw etc. @hcraigmiller can you make a feature request for that?

@SiboVG
Copy link
Member Author

SiboVG commented Jul 30, 2022

@neilweinstock @JoePfeiffer any remarks on this implementation?

@neilweinstock
Copy link
Contributor

I’m not too knowledgeable about the ins and outs of rail buttons.

I feel like all that button configuration doesn’t really accomplish that much until aerodynamics are implemented.

@JoePfeiffer
Copy link
Contributor

Very nice. Like Craig, I'd also like to see screws added, but this is plenty for one PR.

@JoePfeiffer JoePfeiffer merged commit e313546 into openrocket:unstable Jul 31, 2022
@SiboVG SiboVG deleted the issue-1537 branch September 30, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Add more shape configuration parameters for rail button

4 participants