-
-
Notifications
You must be signed in to change notification settings - Fork 532
[#1537] Add additional configuration parameters for rail buttons #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It works welll, but two comments.
I believe this will flow better with those using the tab key to change fields, as well as prevent the potential confusion caused by the substitution of a user entered value with incorrect (yet to be entered) Base Height + Flange Height.
I suggest adding a ScrewHeight field as part of this PR so that all three profiles will be addressed. Functionally, the display height of the rail button would equal Height + Screw Height, and the displayed flange height would equal Flange Height + ScrewHeight. Otherwise, an issue to add the ScrewHeight field can be opened. |
Hm, I'm a bit opposed to adding configuration options for something that the user will not get to see. I'm happy to add the screw height parameter, but only if there is some sort of dropdown menu added to the rail button configuration panel that lets you switch between one of those 3 rail button types. In that case, the rocket view would/should change the rail button's display to match your drawing, and the user would actually see what changing the screw height is doing. For that, I would create a new issue. |
I agree, the above was the math behind it. From a display standpoint, this is what I am proposing (side view). The user would be able to set the screw height, but the diameter of the screw head would be OuterDiameter. There would be no need for the complexity of a drop down to implement this, just the ScrewHeight field. What I was thinking... |
Fair enough. But I won't be including the screwHeight as a parameter for this PR, since that would involve adding visuals for the screw etc. @hcraigmiller can you make a feature request for that? |
|
@neilweinstock @JoePfeiffer any remarks on this implementation? |
|
I’m not too knowledgeable about the ins and outs of rail buttons. I feel like all that button configuration doesn’t really accomplish that much until aerodynamics are implemented. |
|
Very nice. Like Craig, I'd also like to see screws added, but this is plenty for one PR. |



This PR fixes #1537 by adding the following configuration parameters for a rail button:
Demo:
Screen.Recording.2022-07-19.at.00.54.43.mp4