[#1524] Add sliders to PhotoStudio #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
These sliders are going to be my new best friends. Functions as expected, no anomalies found, except as to Issue #874 (Photo Studio smoke effect does not function) still exists. Question: Does this fix, or has Issue #1018 been otherwise fixed? Build 796 |
Member
Author
No, still present. |
Contributor
Indeed. I can't believe it never occurred to me to ask for them before, given how many frustrating hours I have spent playing with those little up/down arrows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1524 by adding sliders to PhotoStudio.
I also noticed that the smoke opacity spinner had no effect on the smoke's opacity, which is fixed in this PR.
I also changed the default spark concentration to 20% instead of 0, so that when you enable sparks, you immediately see the sparks (instead of first having to change the concentration value to something non-zero).
In addition to adding sliders, I also added units for some parameters, such as a percentage unit for the smoke opacity.
Demo:
Screen.Recording.2022-07-12.at.13.03.58.1.mp4