Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Jun 19, 2022

This PR fixes #1465 by including the rocket's xmin position into its sideview origin calculation. For normal rockets, xmin should equal 0, thus nothing should have changed for them. For rockets where some of its child components reach further to the left than their parent component, xmin becomes smaller than zero, which should then also be included in the origin calculation. The design file from #1465 was an example of the child components reaching further to the left. A body tube contained a pod set that was positioned to the left of its parent body tube. Another way of recreating the issue from #1465 is by opening 'A simple model rocket' and moving the launch lug all the way to the left.

image

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Jun 20, 2022

Works well, no anomalies found.

@SiboVG SiboVG merged commit 501f677 into openrocket:unstable Jun 20, 2022
@SiboVG SiboVG deleted the issue-1465 branch September 30, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Side view centering not correct when child component goes outside of parent

2 participants