-
-
Notifications
You must be signed in to change notification settings - Fork 533
Revised installer configuration to enable desktop icon and file associations #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…iations. The major change is it turns out you need to do the file installation before trying to create the integrations.
|
On the Mac it still does not work properly. I believe behavior is unchanged: double-clicking an ORK file in the Finder will activate OR, but it will not open the file. So my interpretation is that the file type is correctly associated in the OS, but the OR code is not properly handling whatever sort of message the OS is sending it to open the file. |
|
Worked perfect on windows, desktop icon, file associations, all good. |
|
That said... if file associations work correctly only on Windows that would still be a useful improvement for beta 4. Mac can be fixed later. |
|
They're also working on linux. Thanks for the link; I'll see if I can use that to get things working on MacOS. Naturally, that's the only one I can't test on! |
|
Here for ya. :) |
|
Is it successfully creating a desktop icon for MacOS, even if the file association isn't working? Briefly looking at that web page, it looks like somebody else's conclusion that it'll take some changes in OR itself and a different main method to get associations working. |
|
I don't see a desktop icon, but that's not a thing for the Mac so I wouldn't expect it. I am seeing proper OR icons in the Finder for the .ork files, so that's good. I think the only remaining issue is the need for the special code in the main method. |
|
Current status: file association and desktop icons work on Linux and Windows. Code that's "supposed" to handle OpenFilesEvent on MacOS is in there, but not working. |
The major change is it turns out you need to do the file installation before trying to create the integrations.
Installers to test in https://drive.google.com/drive/folders/1xaUZXnl9q6CDG-CbkqIQqpFrBz63Gw2k?usp=sharing
Fixes #1135