Skip to content

Conversation

@JoePfeiffer
Copy link
Contributor

@JoePfeiffer JoePfeiffer commented Jun 11, 2022

The major change is it turns out you need to do the file installation before trying to create the integrations.

Installers to test in https://drive.google.com/drive/folders/1xaUZXnl9q6CDG-CbkqIQqpFrBz63Gw2k?usp=sharing

Fixes #1135

…iations.

The major change is it turns out you need to do the file installation before trying to create the integrations.
@neilweinstock
Copy link
Contributor

On the Mac it still does not work properly. I believe behavior is unchanged: double-clicking an ORK file in the Finder will activate OR, but it will not open the file.

So my interpretation is that the file type is correctly associated in the OS, but the OR code is not properly handling whatever sort of message the OS is sending it to open the file.

@hcraigmiller
Copy link
Collaborator

Worked perfect on windows, desktop icon, file associations, all good.

@neilweinstock
Copy link
Contributor

That said... if file associations work correctly only on Windows that would still be a useful improvement for beta 4. Mac can be fixed later.

@neilweinstock
Copy link
Contributor

@JoePfeiffer
Copy link
Contributor Author

They're also working on linux. Thanks for the link; I'll see if I can use that to get things working on MacOS. Naturally, that's the only one I can't test on!

@JoePfeiffer JoePfeiffer marked this pull request as draft June 12, 2022 00:39
@neilweinstock
Copy link
Contributor

Here for ya. :)

@JoePfeiffer
Copy link
Contributor Author

Is it successfully creating a desktop icon for MacOS, even if the file association isn't working?

Briefly looking at that web page, it looks like somebody else's conclusion that it'll take some changes in OR itself and a different main method to get associations working.

@neilweinstock
Copy link
Contributor

I don't see a desktop icon, but that's not a thing for the Mac so I wouldn't expect it. I am seeing proper OR icons in the Finder for the .ork files, so that's good. I think the only remaining issue is the need for the special code in the main method.

@JoePfeiffer
Copy link
Contributor Author

Current status: file association and desktop icons work on Linux and Windows. Code that's "supposed" to handle OpenFilesEvent on MacOS is in there, but not working.

@JoePfeiffer JoePfeiffer marked this pull request as ready for review June 14, 2022 16:34
@SiboVG SiboVG merged commit 1d3fea6 into openrocket:unstable Jun 14, 2022
@JoePfeiffer JoePfeiffer deleted the fix-1135 branch June 14, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get file associations working correctly on packaged installers

4 participants