Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Jun 7, 2022

Fixes #1411. I’ve made it so that the name just displays ‘Components ’, with all the names of the selected components as a description (second line) in the hover box. If the component selection contains a component with children, it will also give the total mass of that parent component, just as is now the case if you hover over the body tube in ‘A simple model rocket’. For instance if you select the nose cone and body tube in ‘A simple model rocket’, it will display ‘Components (28.5 g of 48.1 g total)’. If no parent components are present, it just shows ‘Components (28.5 g)’. Another special case is if you select a stage or rocket (together with other components). In that case it just shows ‘Components ()’, but with the sustainer and all other components included in the hover description.

(I decided the first line just needs to say ‘Components’ instead of the full list of components, because otherwise you would have to pass your focus all the way to the end of the hover box to finally see the actual mass. The component list is also not really important, that’s why it’s just on the description line.

Anyway too much talking from me, here’s a demo to make it all clear:

Screen.Recording.2022-06-07.at.15.22.49.mp4

Here is a jar file for testing.

@hcraigmiller
Copy link
Collaborator

That's really nice...

Functions as expected, no anomalies found.

[Windows 11 Pro, Version 21H2, OS Build 22000.675, Windows Feature Experience Pack 1000.22000.675.0]
[Java version "17.0.3.1" 2022-04-22 LTS; Java(TM) SE Runtime Environment (build 17.0.3.1+2-LTS-6)]

@SiboVG SiboVG merged commit 213a9b9 into openrocket:unstable Jun 7, 2022
@SiboVG SiboVG deleted the issue-1411 branch June 7, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Show combined mass of multi-selection hover in component tree

2 participants