Add PowerMockRunnerDelegateToRunWith recipe#940
Merged
Conversation
Handles @PowerMockRunnerDelegate by promoting the delegate runner to @RunWith and removing the PowerMock-specific annotation and imports.
timtebeek
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PowerMockRunnerDelegateToRunWithrecipe that handles@PowerMockRunnerDelegateduring PowerMock-to-Mockito migrationReplacePowerMockitoinpowermockito.yml, positioned beforePowerMockitoMockStaticToMockitoProblem
The
Mockito1to3Migrationrecipe does not handle the@PowerMockRunnerDelegateannotation (org.powermock.modules.junit4.PowerMockRunnerDelegate). When a test class uses both@RunWith(PowerMockRunner.class)and@PowerMockRunnerDelegate(SpringJUnit4ClassRunner.class), the migration removes@RunWith(PowerMockRunner.class)but leaves@PowerMockRunnerDelegateuntouched, producing invalid code since the PowerMock dependency is no longer present.Background research
@PowerMockRunnerDelegatewas introduced in PowerMock 1.6.0 to solve a JUnit 4 limitation: only one@RunWithrunner can be specified per test class. When a test needs both PowerMock's bytecode manipulation and another runner (e.g., Spring'sSpringJUnit4ClassRunneror JUnit'sParameterized), the pattern is:PowerMockRunnerhandles classloading and@PrepareForTestsetup, then delegates actual test execution to the runner specified in@PowerMockRunnerDelegate. The delegate is the runner the test actually depends on.When removing PowerMock, the correct migration is to promote the delegate to
@RunWith, since:PowerMockRunnerwas only a wrapper for classloader tricks — it serves no purpose without PowerMockSources