Fix AssertThrowsOnLastStatement crash on TypeCast arguments#933
Merged
Fix AssertThrowsOnLastStatement crash on TypeCast arguments#933
Conversation
Add `J.TypeCast` to the early-return filter in `extractExpressionArguments` so cast expressions like `(Object[]) null` are left in place rather than being extracted into variable declarations, which fails for array cast types. Fixes openrewrite/rewrite#7082
|
What is the new version @timtebeek ? |
Member
Author
|
There is a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
IllegalArgumentExceptioninAssertThrowsOnLastStatementwhen the last lambda statement has aJ.TypeCastargument like(Object[]) nullAdds
J.TypeCastto the early-return filter inextractExpressionArgumentsso cast expressions are left in place rather than extracted into variable declarationsAdds test case reproducing the issue
Fixes IllegalArgumentException: Expected a template that would generate exactly one statement to replace one statement, but generated 0 rewrite#7082