Dont convert try catch fail when return#566
Merged
Conversation
timtebeek
approved these changes
Aug 8, 2024
Member
timtebeek
left a comment
There was a problem hiding this comment.
Great work already; one case was missed for nested elements. I've added a quick pattern we use more often when we want to search downwards from a particular elements to handle that correctly. See if you can work out why and how that works. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Add check for try bodies that contain a return statement
What's your motivation?
Solves #547
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@timtebeek @protocol7
Have you considered any alternatives or workarounds?
Any additional context
Checklist