Convert assertThrows with an Executable variable#1046
Merged
Conversation
…rowingCallable` Fixes #511
timtebeek
commented
Jun 20, 2026
…owingCallable type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JUnitAssertThrowsToAssertExceptionTypedoes not convert cases whereexecutableis a variable #511Problem
JUnitAssertThrowsToAssertExceptionTypewas already rewritingassertThrows(..., executable)intoassertThatExceptionOfType(...).isThrownBy(executable)even whenexecutableis a variable, but the result did not compile: the variable stayed typed as JUnit'sorg.junit.jupiter.api.function.Executable, while AssertJ'sisThrownByrequiresThrowableAssert.ThrowingCallable. These are distinct functional interfaces — a lambda/method reference coerces to either, a typed variable does not.Change
When the executable argument is a variable typed exactly as
Executable, the recipe now also retypes its declaration (and references) toThrowingCallable, adding/removing imports accordingly.This is guarded: the conversion only proceeds when every usage of that variable is an
assertThrowsexecutable argument (or the variable's own declaration/assignment). If the same variable is also passed somewhere that requires anExecutable(e.g.assertAll), the types can't both be satisfied, so the call is left untouched rather than emitting non-compiling code.Tests
variableExecutable— local variable (the issue's core case)variableExecutableWithMessage— 3-arg form with.as(...)fieldExecutable— field declarationdoNotRetypeExecutableSharedWithOtherJUnitAssertion— guard: variable shared withassertAllis left unchanged