SimplifyMockitoVerifyWhenGiven does not replace org.mockito.Mockito(..) #634
Description
What version of OpenRewrite are you using?
I am using
- Maven/Gradle plugin v5.43.2
- rewrite-testing-frameworks v2.21.0
How are you running OpenRewrite?
Using the mvn plugin with a multi project module
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.testing.mockito.SimplifyMockitoVerifyWhenGiven -Drewrite.exportDatatables=true
What is the smallest, simplest way to reproduce the problem?
I will propose a PR shortly with a unit test :
import static org.mockito.Mockito.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
class Test {
void test() {
var mockString = mock(String.class);
verify(mockString).replace(eq("foo"), eq("bar"));
}
}What did you expect to see?
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
class Test {
void test() {
var mockString = mock(String.class);
verify(mockString).replace("foo", "bar");
}
}What did you see instead?
import static org.mockito.Mockito.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
class Test {
void test() {
var mockString = mock(String.class);
verify(mockString).replace(eq("foo"), eq("bar"));
}
}Are you interested in contributing a fix to OpenRewrite?
I will propose a PR shortly with a unit test and a potential improvement