Improve JakartaXmlWs recipe#735
Merged
Merged
Conversation
…pgrade more robust
timtebeek
approved these changes
May 19, 2025
Member
|
There's some unrelated test failures that we're still flushing out; we'll merge this either way. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
providedscope in the Jakarta XML WS recipeWhat's your motivation?
#730
Anything in particular you'd like reviewers to focus on?
Unsure if the
jaxws-rtdependency is still needed when upgrading to EE9. Maybe it could be removed? but for now making itprovidedscope similar to what gets added viarewrite-migrate-java/src/main/resources/META-INF/rewrite/java-version-11.yml
Line 235 in 88a1c90
Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
Any additional context
Checklist