Add mapping for migration for joda LocalDate by YarochkinMichael · Pull Request #677 · openrewrite/rewrite-migrate-java

YarochkinMichael · 2025-02-18T06:44:57Z

What's changed?

Added mapping for joda LocalDate to java LocalDate

Anyone you would like to review specifically?

@amishra-u
@timtebeek
Recipe is still not updating the field as it is used further in the code.
In the snippet below, for example;

il1 will not be updated, if2 will.
when I use id2 on line 3, then it will also be skipped, but ld1 updated
if i remove line 3 both line 1 and 2 will be updated

LocalDate ld1 = new LocalDate();
LocalDate ld2 = new LocalDate(0L);
LocalDate ld7 = ld1.plusDays(5);

Checklist

No unit tests

YarochkinMichael · 2025-02-18T07:02:15Z

The update issue is fixed by the second commit

YarochkinMichael · 2025-02-18T17:03:44Z

Add LocalDateTime mapping
Add tests

amishra-u · 2025-02-18T17:07:52Z

src/main/java/org/openrewrite/java/migrate/joda/JodaTimeVisitor.java

        }
        MethodTemplate template = AllTemplates.getTemplate(original);
        if (template == null) {
+            //is it a better way to print logs?


Can you generate datatable for unhandled case?
https://docs.openrewrite.org/authoring-recipes/data-tables
or atleast use ExecutionContext messaging for unhandled case.
https://javadoc.io/doc/org.openrewrite/rewrite-core/8.19.0/org/openrewrite/InMemoryExecutionContext.html

Not sure how big your repo is but the datatable will be very useful for large repos.

Can you give me example usage of how to print log line please?

Hi @YarochkinMichael 👋 you can find out documentation on how to generate data tables from recipes here https://docs.openrewrite.org/authoring-recipes/data-tables#generating-the-data-table

amishra-u · 2025-02-18T17:10:08Z

src/main/java/org/openrewrite/java/migrate/joda/templates/LocatDateTemplates.java

+        }
+    };
+
+    private JavaTemplate build(JavaTemplate.Builder builder) {


amishra-u · 2025-02-18T17:23:20Z

src/test/java/org/openrewrite/java/migrate/joda/NoJodaTimeTest.java

@@ -43,12 +43,16 @@ void migrateJodaTime() {
              java(


Could you add a test case for each template? This will at least ensure basic verification for each one.

FYI: If you use GitHub Copilot or ChatGPT, you’ll be surprised at how well they generate these test cases.

I added a no-arg constructor. locally, for testing, I have a project with examples. After I finish migration, I will have more time to move it to tests.

Most of my code is generated by ChatGPT. ;)

Hi @YarochkinMichael tests are crucial for us and we require a decent test coverage.
Please see our guides here on creating RewriteTests easily.

YarochkinMichael · 2025-02-19T07:47:27Z

Add LocalTime mapping

Add Hours mapping

YarochkinMichael · 2025-02-21T13:03:15Z

I was able to fix all my use cases. Not all Joda types are mapped, but now it is printing message about missing mapping.

@amishra-u please have a look into my last commit. on my side class variables are migrated without any issues.

TODO: add tests. i have a local project I was using for testing. Need to turn it into unit tests.

src/main/java/org/openrewrite/java/migrate/joda/templates/DaysTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/HoursTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/SecondsTemplates.java

YarochkinMichael · 2025-02-23T21:50:47Z

@amishra-u can you pls check my "fix" for class wars?

YarochkinMichael · 2025-02-23T21:58:14Z

Not only did the tests with my changes fail.

amishra-u · 2025-02-24T20:16:27Z

Not only did the tests with my changes fail.

Yes, it failed as expected

Refer to this field to disable safeMigration a better way.

rewrite-migrate-java/src/main/java/org/openrewrite/java/migrate/joda/JodaTimeVisitor.java

Line 44 in 548f4db

this.safeMigration = safeMigration;

amishra-u · 2025-02-24T20:27:02Z

Before this PR can be merged, please address the following:

Ensure unit tests are included—they are essential.
Avoid merging multiple features in one PR. For example, adding new templates and disabling optional safe migration should be separate.

Alternatively, you can create a local copy of the JAR with these changes and use it in your project, skipping the PR process. If someone else needs the same feature later, they can take over and upstream it.

PS: I’m not on the maintainer list—this is just my general advice.

YarochkinMichael · 2025-02-25T09:27:59Z

@amishra-u
thank you for the reply

My question about "safe" is more about whether it is possible just to disable it. If so, I will remove it completely. The code you see now is mostly for the test. And allow me to continue my work, of course. :)

Removing the "safe" feature is a part of migration. I can extract it in a separate PR. But it makes no sense to me.

…ng-to-joda-recipe' into add-localdate-mapping-to-joda-recipe # Conflicts: # src/main/java/org/openrewrite/java/migrate/joda/templates/PeriodTemplates.java

…cipe

merge master

github-actions

Some suggestions could not be made:

src/main/resources/META-INF/rewrite/examples.yml
- lines 5772-5771
- lines 5786-5785

src/main/java/org/openrewrite/java/migrate/joda/templates/AbstractDurationTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/AbstractPeriodTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/ChronologyTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/HoursTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/LocatDateTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/MinutesTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/PeriodTemplates.java

src/main/java/org/openrewrite/java/migrate/joda/templates/SecondsTemplates.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

timtebeek · 2025-06-02T09:23:53Z

Ideally we see the changes from #676 adopted here, or after this is merged.

…cipe

# Conflicts: # src/main/java/org/openrewrite/java/migrate/joda/JodaTimeVisitor.java

timtebeek · 2025-08-26T18:04:06Z

As discussed, let's move this over to https://github.com/openrewrite/rewrite-joda

Thanks again!

Add mapping for migration for joda LocalDate

bce32bb

Mikhail.Yarochkin and others added 2 commits February 18, 2025 08:52

Fix safe migration issue.

0ed4bf2

Merge branch 'main' into add-localdate-mapping-to-joda-recipe

fa80bf7

timtebeek self-requested a review February 18, 2025 12:53

timtebeek assigned YarochkinMichael Feb 18, 2025

Add LocalDateTime mapping

4d2d32f

amishra-u reviewed Feb 18, 2025

View reviewed changes

Add LocalTime mapping

d058821

Mikhail.Yarochkin added 3 commits February 19, 2025 17:18

Add Seconds mapping

d5f61bc

Add Days mapping

e16c12d

Add Hours mapping

Add tests

ccbc050

YarochkinMichael mentioned this pull request Feb 20, 2025

org.openrewrite.java.migrate.joda.JodaTimeRecipe not changing anything openrewrite/rewrite-joda#12

Closed

Disable safe check in Visitor

37eb88c

github-actions bot reviewed Feb 23, 2025

View reviewed changes

Mikhail.Yarochkin and others added 7 commits March 4, 2025 08:17

add additional mappings

53f40df

add additional mappings

86e5b1d

add additional mappings

8b466aa

Update .gitlab-ci.yml file

3fc49b1

fix assignment to primitive

6a6008b

add mappings

60c7759

Fix mappings

015df71

Mikhail.Yarochkin and others added 6 commits April 2, 2025 12:46

Add mappings

6036bb2

Merge remote-tracking branch 'refs/remotes/origin/add-localdate-mappi…

214b137

…ng-to-joda-recipe' into add-localdate-mapping-to-joda-recipe # Conflicts: # src/main/java/org/openrewrite/java/migrate/joda/templates/PeriodTemplates.java

Merge branch 'refs/heads/main' into add-localdate-mapping-to-joda-recipe

c8b70f8

Add mappings

bf618b5

Merge branch 'openrewrite:main' into add-localdate-mapping-to-joda-re…

dc0f687

…cipe

Merge pull request #1 from YarochkinMichael/main

26b04fe

merge master

timtebeek removed their request for review May 6, 2025 14:51

Merge branch 'main' into add-localdate-mapping-to-joda-recipe

272cab9

github-actions bot reviewed May 6, 2025

View reviewed changes

timtebeek and others added 2 commits May 6, 2025 16:59

Apply suggestions from code review

a0dedc0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update build.gradle.kts

3774163

YarochkinMichael and others added 6 commits June 10, 2025 22:13

Merge branch 'openrewrite:main' into add-localdate-mapping-to-joda-re…

a08d224

…cipe

Merge branch 'openrewrite:main' into add-localdate-mapping-to-joda-re…

890ff0f

…cipe

Add mappings

d757bf8

Fix tests

f2bdd45

Merge branch 'refs/heads/main' into add-localdate-mapping-to-joda-recipe

27c79d7

# Conflicts: # src/main/java/org/openrewrite/java/migrate/joda/JodaTimeVisitor.java

Merge branch 'main' into add-localdate-mapping-to-joda-recipe

f841f60

timtebeek mentioned this pull request Aug 11, 2025

Joda-time: Make safe migration optional #811

Merged

timtebeek closed this Aug 26, 2025

github-project-automation bot moved this from In Progress to Done in OpenRewrite Aug 26, 2025

Conversation

YarochkinMichael commented Feb 18, 2025

What's changed?

Anyone you would like to review specifically?

Checklist

Uh oh!

YarochkinMichael commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YarochkinMichael commented Feb 18, 2025

Uh oh!

amishra-u Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

YarochkinMichael Feb 18, 2025 • edited by jevanlingen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MBoegers Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

amishra-u Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

amishra-u Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

YarochkinMichael Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

YarochkinMichael Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

MBoegers Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

YarochkinMichael commented Feb 19, 2025

Uh oh!

YarochkinMichael commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YarochkinMichael commented Feb 23, 2025

Uh oh!

YarochkinMichael commented Feb 23, 2025

Uh oh!

amishra-u commented Feb 24, 2025

Uh oh!

amishra-u commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YarochkinMichael commented Feb 25, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timtebeek commented Jun 2, 2025

Uh oh!

timtebeek commented Aug 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YarochkinMichael commented Feb 18, 2025 •

edited

Loading

YarochkinMichael Feb 18, 2025 •

edited by jevanlingen

Loading

amishra-u commented Feb 24, 2025 •

edited

Loading