Adding all org.glassfish.main migrations to jakarta#517
Adding all org.glassfish.main migrations to jakarta#517timtebeek merged 4 commits intoopenrewrite:mainfrom
Conversation
timtebeek
left a comment
There was a problem hiding this comment.
Great to see, thanks! Couple of quick questions as I went over the artifactIds; if you could answer those I think we can merge soon after.
For Yaml only recipes it's not always necessary to write a test; in some cases that might bring to light dependencies that can't be found, as might have been the case here. No need to add them now I'd say.
Co-authored-by: Tim te Beek <timtebeek@gmail.com>
timtebeek
left a comment
There was a problem hiding this comment.
Thanks for the work done here and educating me on the changes. :)
|
Thanks for your help! However, I did an oopsie by thinking your thumbs-up in the discussion for org.glassfish:jakarta.faces meant that I should re-add the migration with another target. I think we should revert commit 124cb01 to re-delete the jsf migration. |
As discussed on #517 (comment)
|
Thanks! Dropped now in 61ed4bc |
What's changed?
Added migrations for all Java EE APIs under the organization org.glassfish.main. Added a migration for java.ejb:javax.ejb to jakarta.ejb. These changes are implemented in the org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta Recipe.
What's your motivation?
https://rewriteoss.slack.com/archives/C01A843MWG5/p1721228381110469
Any additional context
Should I implement tests for each case? As far as I see the other migrations of this recipe don't have tests and I'm not sure what for I would be testing other than typos anyways.
Checklist