Conversation
Opinionated recipe that builds on UpgradeToJava25 with additional best practices: NoGuava, JSpecify, targeted UseVar, and broadly accepted static analysis improvements.
PrimitiveWrapperClassConstructorToValueOf and BigDecimalRoundingConstantsToEnums are already included transitively via Java8toJava11.
Add stdlib preference recipes (UseEnumSetOf, UseListOf, UseSetOf, UseStringIsEmpty), bug prevention (ReplaceWeekYearWithYear, RemoveHashCodeCallsFromArrayInstances, RemoveToStringCallsFromArrayInstances, UseObjectNotifyAll, RemoveCallsToSystemGc, RemoveCallsToObjectFinalize), and modernization (UseStandardCharset, UseSystemLineSeparator, RemoveRedundantTypeCast, ReplaceStackWithDeque, UseListSort, EqualsToContentEquals).
Removed UseStringIsEmptyRecipe from Java best practices.
UseVarForGenericsConstructors/UseVarForGenericMethodInvocations must run before UseDiamondOperator to preserve the explicit type arguments needed for var inference.
3 tasks
Include UseMapOf alongside UseListOf, UseSetOf, and UseEnumSetOf for consistent coverage of modern collection factory methods.
MBoegers
approved these changes
Mar 24, 2026
Contributor
MBoegers
left a comment
There was a problem hiding this comment.
Added UseMapOf for completeness — the collection factories section now covers List, Set, Map, and EnumSet uniformly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.openrewrite.java.migrate.JavaBestPracticesrecipe that builds on the full Java 25 upgrade chain with opinionated best practicesvarusage (UseVarForTypeCast,UseVarForGenericsConstructors,UseVarForGenericMethodInvocations), andUseTextBlockswithconvertStringsWithoutNewlines: trueUseStringReplaceRemoveUnusedImportsas a cleanup passTest plan
./gradlew test --tests JavaBestPracticesTestpasses