Skip to content

maven.compiler.release set in parent is not recognized in child module #523

@pzygielo

Description

@pzygielo

maven.compiler.release which is defined in parent is not recognized in child module and patch for explicit overriding property is generated by UpgradeToJava17 recipe.

What version of OpenRewrite are you using?

I am using

  • rewrite-migrate-java 2.21.0
  • Maven plugin 5.37.1

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a multi-module project.

What is the smallest, simplest way to reproduce the problem?

https://github.com/pzrep/openrewrite-migrate-compiler-release-in-child/

What did you expect to see?

No patch generated by recipe as property inherited from parent is good enough.

What did you see instead?

Patch generated by recipe (step: Show applied changes): https://github.com/pzrep/openrewrite-migrate-compiler-release-in-child/actions/runs/10196871940/job/28208511361?pr=2

diff --git a/child/pom.xml b/child/pom.xml
index 96186f3..2570020 100644
--- a/child/pom.xml
+++ b/child/pom.xml
@@ -8,5 +8,8 @@
         <version>1-SNAPSHOT</version>
     </parent>
     <artifactId>openrewrite-migrate-compiler-release-in-child.child</artifactId>
+    <properties>
+        <maven.compiler.release>17</maven.compiler.release>
+    </properties>

8d15935#commitcomment-144892557

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions