Move EnableLombokAnnotationProcessor from UpgradeToJava25 to
UpgradeToJava17, where the maven-compiler-plugin bump to 3.x
actually breaks implicit annotation processor discovery (JEP 477).
Java 21 and 25 inherit this via chaining. Fixes Lombok compilation
failures (cannot find symbol for getter/setter) after upgrade.

Closes moderneinc/customer-requests#1949

* Also upgrade maven-surefire-report-plugin to 3.5.x

Updated versions for maven-surefire-plugin and maven-failsafe-plugin to 3.5.x.

* Update Maven plugin versions in UpgradeToJava25Test

…lvable types (#1005)

* Fix `IfElseIfConstructToSwitch` dropping pattern variables for unresolvable types

When JavaTemplate can't resolve a non-JDK type during switch case
generation, it may not produce a J.VariableDeclarations AST node,
causing pattern variable declarations to be dropped (e.g.,
`case Dog d ->` becomes `case Dog ->`).

Fix by using positional case identification instead of type-checking
the label, and reconstructing a proper J.VariableDeclarations from
the original J.InstanceOf when the template parser fails to produce
one.

Fixes #1004

* Use `ListUtils.map` with index

Remove `@AllArgsConstructor` from `ReplaceAWTGetPeerMethod` and
`ReplaceComSunAWTUtilitiesMethods` and replace the no-arg `@JsonCreator`
constructor with an all-args `@JsonCreator` constructor accepting
`@Nullable` parameters with defaults. This eliminates the conflicting
property-based creators caused by Lombok's `@ConstructorProperties`
annotation on the generated all-args constructor.

Closes #1003

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <team@moderne.io>

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.migrate.lombok.LombokBestPractices?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl

Co-authored-by: Moderne <team@moderne.io>

Remove @requiredargsconstructor which generates @ConstructorProperties on the all-args constructor, conflicting with the no-arg @JsonCreator. Change @JsonCreator to accept nullable parameters with defaults, matching the pattern from #1007.

This resolves the InvalidDefinitionException: Conflicting property-based creators reported in issue #1003.

Reorder recipes so IfElseIfConstructToSwitch runs before the switch expression conversion recipes. This ensures that if-else-if instanceof chains are converted to switches, then immediately to switch expressions in a single pass, instead of requiring two runs (fixes #1011).

* Fix IfElseIfConstructToSwitch null safety regression (issue #1013)

When converting instanceof chains to switch without an explicit null check,
emit `case null, default` instead of just `default` to preserve instanceof's
null-safe behavior. Previously, the recipe would generate code that throws NPE
when the switched variable is null, unlike the original if-else chain.

* Fix UpgradeToJava21Test expectation for case null, default

… and bring in line with Jetty EE9 list (#1017)