Comparing changes

…e-buddy (#981) * Add UpgradePluginsForJava25 for surefire, failsafe, compiler, and byte-buddy Closes moderneinc/customer-requests#1820 * Regenerate recipes.csv * Move `SetupJavaUpgradeJavaVersion` for consistency * Use `.actual()` * Apply suggestions * Move comment --------- Co-authored-by: Tim te Beek <tim@mac.home>

@issue

* Add failing test for superclass method check When a class extends a superclass that already has the method implementation, AddMissingMethodImplementation should not add the method again. Reproduces moderneinc/customer-requests#1862 * Skip adding methods already provided by a superclass AddMissingMethodImplementation now walks up the superclass chain to check if the method is already inherited, avoiding unnecessary duplicate method additions to classes like HikariDataSource subclasses. Fixes moderneinc/customer-requests#1862 * Remove @issue annotation pointing to private repo

Skip text block conversion if any comments exist in the binary expression tree, since text blocks (single J.Literal nodes) have nowhere to preserve inline comments from the middle of concatenations. Co-authored-by: Tim te Beek <tim@mac.home>

@DaTa

* Prevent LombokValToFinalVar from removing star imports LombokValToFinalVar unconditionally called `maybeRemoveImport("lombok.var")` in `visitCompilationUnit` on every file matching the `MaybeUsesImport` precondition. This matched files with `import lombok.*;` even when no val/var was used. In multi-module projects with incomplete type information, `maybeRemoveImport` could not determine that other lombok types (like @DaTa, @Getter) were still referenced, and removed the entire star import. Now only calls `maybeRemoveImport` when there is an explicit `import lombok.var;` statement, leaving star imports untouched. Fixes #962 * Apply suggestions from code review * Apply suggestion from @Jenson3210

…s present (#987) * Retain javax.xml.bind:jaxb-api when jackson-module-jaxb-annotations is present When migrating from javax.xml.bind to jakarta.xml.bind 3.0+, the ChangeDependency recipe replaces javax.xml.bind:jaxb-api entirely. However, jackson-module-jaxb-annotations still depends on the javax.xml.bind namespace at runtime through its transitive dependency on jakarta.xml.bind:jakarta.xml.bind-api:2.3.x (the bridge version). When version resolution upgrades to 3.0.x+, the javax.xml.bind classes disappear, causing NoClassDefFoundError. This adds a RetainJaxbApiForJackson recipe that re-adds javax.xml.bind:jaxb-api as a runtime dependency when jackson-module-jaxb-annotations is detected on the classpath, for both Gradle and Maven projects. Fixes #504 * Update recipes.csv with RetainJaxbApiForJackson * Replace imperative recipe with declarative YAML, use actual() in tests Address PR feedback: - Replace imperative RetainJaxbApiForJackson.java with declarative YAML recipes using FindDependency preconditions (split into Gradle and Maven variants since ModuleHasDependency is a ScanningRecipe which doesn't work as a declarative precondition) - Use assertThat().actual() instead of return in test assertions * Update recipes.csv for new declarative recipes * Consolidate into single declarative recipe using DependencyInsight precondition Replace the Gradle/Maven split with a single declarative recipe that uses DependencyInsight as a cross-platform precondition instead of build-system specific FindDependency recipes.

…989) When maven-compiler-plugin has no <version> tag and uses <source>/<target>, the migration converts to <release> but the default plugin version (3.1) doesn't support it. Set addVersionIfMissing on UpgradePluginVersion so a compatible version is always present.