Marking files not containing JavaProject marker if invertMarking is also true, as they vacuously would not have a particular dependency in real-world scenarios#147
Merged
Conversation
…is also true, as they vacuously would not have a particular dependency in real-world scenarios. This mostly crops up during our tests in reality.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ow it's complaining about lack of a new line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mostly crops up during our tests in reality.
What's changed?
During the visitor, if you detect that a file does not have a
JavaProjectmarker, we normally would return back unchanged early. With this change, if you are also instructingModuleHasDependencyto invert the marking (i.e. mark files that are part of a module that does not contain the dependency instead), now it will also mark files that do not have the marker at all.Checklist