Update FindCallGraphTest to expect void for Kotlin Unit return type#43
Merged
Merged
Conversation
Non-nullable kotlin.Unit return types now map to JVM void as of rewrite 8.79.4 (openrewrite/rewrite#7364). Update the call graph assertion to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FindCallGraphTest.companionObject()assertsreturnType=kotlin.Unit, but the parser now producesvoid.kotlin.Unitreturn types are intentionally mapped to JVMvoidas of rewrite 8.79.4 (Align Kotlin type model with Java parser output rewrite#7364 — "Align Kotlin type model with Java parser output"), so the test expectation is stale.Test plan
./gradlew test --tests FindCallGraphTest.companionObjectpasses against rewrite 8.79.4+